Fix misplaced/mistyped per-file-ignores in flake8 #2509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR gets rid of the invalid ignore entries in the flake8 config. They were introduced in 313ac58 while being moved from the pytest config. The correct flake8 syntax is
per-file-ignoreswith colon-separated entries.I'm pretty sure this never worked.
Also,
setuptools/site-patch.pydoesn't even exist anymore +setuptools/py*compat.pymatchessetuptools/py34compat.pythat doesn't generate any violations meaning that introducing the correctper-file-ignoresis currently unnecessary.Refs:
Pull Request Checklist
changelog.d/.(See documentation for details)