Some small typos and grammar fixes #3286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Tense changed in first paragraph: should be either past or present; present seems fair since a lot of people still use or even need `setup.py`.
- Line 20: missing 'the'
- Under 'How to use it?' I added a Python file to the source tree; seems like the sort of thing a beginner could get confused about ("where does my code go?").
- A couple of small typos.
abravalheri
reviewed
Apr 27, 2022
docs/build_meta.rst
Outdated
| meowpkg/__init__.py | ||
| meowpkg/ | ||
| __init__.py | ||
| meowpkg.py |
There was a problem hiding this comment.
Should we change the name of this second file to be something different from the package name? Maybe this can be confusing.
abravalheri
reviewed
Apr 27, 2022
abravalheri
reviewed
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
setup.py.Pull Request Checklist
changelog.d/].I was doubtful that these changes warranted this.