Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing error prone undefined late binding for Darwin builds #3852

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rickmark
Copy link

@rickmark rickmark commented Mar 9, 2023

This flag causes the linker to succeed and insert dlsym for undefined values which will cause numerious run time issues that are compile time issues with ext modules

Summary of changes

Do not request darwin (macOS) linker to ignore undefined symbols

Closes

Pull Request Checklist

This flag causes the linker to succeed and insert dlsym for undefined
values which will cause numerious run time issues that are compile time
issues with ext modules
@rickmark
Copy link
Author

Additionally I think setuptools may have to be modernized for clang on Apple platforms, including using -bundle instead of dynamiclib.

The additional linker stripping statement might also only be for when compiling as debug

@jaraco
Copy link
Member

jaraco commented Jun 21, 2023

Can you give an example of how the existing behavior has caused issues? It may be worthwhile to create a test that captures the expected behavior, so that someone wishing to re-introduce this flag would have a reason not to. I acknowledge that the code isn't particularly robust, so I'd like to use this opportunity to help make it more robust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants