Use set instead of True-only dict
#4366
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
force-pushed
the
Use-set-instead-of-True-only-dict
branch
from
058f83a
to
8fcc472
Compare
…m/Avasam/setuptools into Use-set-instead-of-True-only-dict
…m/Avasam/setuptools into Use-set-instead-of-True-only-dict
|
Thank you very much for the continuous contributions, @Avasam
Can we live without this one? Maybe if it is a breaking change we can step back? |
Since v70 just got published, I'll make a version of this PR that doesn't touch public names (let me know if any of the 4 public names listed above were not meant as public api anyway). So this can be considered for v71 instead.
I don't think so, it's just a datatype improvement. |
…t-instead-of-True-only-dict
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Use
setinstead ofTrue-onlydictNote this is likely a breaking changes for some downstream users of
pkg_resources.ResourceManager.cached_filessetuptools.package_index.PackageIndex.package_pages's valuessetuptools.package_index.PackageIndex.scanned_urlssetuptools.package_index.PackageIndex.fetched_urlsif they access of modify its content.
Pull Request Checklist
newsfragments/.(See documentation for details)