Reinstate the or guard in WorkingSet._markers_pass #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm still a little uneasy about substituting an empty tuple for a single item list of empty string... but at least now the expectation that the False value will be an empty tuple is captured. I can work with that. Thanks. |
|
In 8ce73d4, I've finished up another refactor which attempts to simplify the implementation and clarify the expectation when no extras were indicated (not weirdly allowing |
|
A better perspective is these two commits together. |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @jaraco refactoring the marker evaluation in WorkingSet.resolve(), we can test it directly to show that the [''] guard is required.