Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg_resources.SetuptoolsVersion is not available anymore in setuptools 39 #223

Closed
anntzer opened this issue Mar 18, 2018 · 2 comments
Closed

pkg_resources.SetuptoolsVersion is not available anymore in setuptools 39 #223

anntzer opened this issue Mar 18, 2018 · 2 comments
Labels
bug upstream-broke-us

Comments

@anntzer
Copy link
Contributor

anntzer commented Mar 18, 2018

xref pypa/setuptools@eeeb9b2

the warning at

setuptools_scm/setuptools_scm/version.py

Line 17 in fc824aa

def _warn_if_setuptools_outdated():
is now incorrect.
@RonnyPfannschmidt
Copy link
Contributor

@jaraco - im wondering how to best resolve this, i believe i have to make a cut in supported setuptools versions

@RonnyPfannschmidt
Copy link
Contributor

i checked history, the best solution forward is to parse a version, if its a tuple bail out completely, else use the strict version type obtained by parsing the version

RonnyPfannschmidt added a commit that referenced this issue Mar 19, 2018
@RonnyPfannschmidt
Merge pull request #224 from RonnyPfannschmidt/parse-version-fix
6e9b5dd 
fix #223 - dont depend on SetuptoolsVersion as its dropped in v39
This was referenced Mar 20, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug upstream-broke-us
Projects
None yet
Milestone
No milestone
2 participants
@RonnyPfannschmidt @anntzer