Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failures with python 3.8 #335

Closed
opoplawski opened this issue May 11, 2019 · 1 comment · Fixed by #336
Closed

Test failures with python 3.8 #335

opoplawski opened this issue May 11, 2019 · 1 comment · Fixed by #336

Comments

@opoplawski
Copy link

Seeing test failures like the following with python 3.8:

=================================== FAILURES ===================================
__________________________ test_version_from_pkginfo ___________________________
wd = <conftest.Wd object at 0x7f7349a79bb0>
    def test_version_from_pkginfo(wd):
        wd.write("PKG-INFO", "Version: 0.1")
>       assert wd.version == "0.1"
testing/test_basic_api.py:28: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
../../BUILDROOT/python-setuptools_scm-3.3.0-1.fc31.x86_64/usr/lib/python2.7/site-packages/setuptools_scm/__init__.py:146: in get_version
    parsed_version = _do_parse(config)
../../BUILDROOT/python-setuptools_scm-3.3.0-1.fc31.x86_64/usr/lib/python2.7/site-packages/setuptools_scm/__init__.py:96: in _do_parse
    ) or _version_from_entrypoint(
../../BUILDROOT/python-setuptools_scm-3.3.0-1.fc31.x86_64/usr/lib/python2.7/site-packages/setuptools_scm/__init__.py:52: in _version_from_entrypoint
    version = _call_entrypoint_fn(config, ep.load())
../../BUILDROOT/python-setuptools_scm-3.3.0-1.fc31.x86_64/usr/lib/python2.7/site-packages/setuptools_scm/__init__.py:38: in _call_entrypoint_fn
    if function_has_arg(fn, "config"):
../../BUILDROOT/python-setuptools_scm-3.3.0-1.fc31.x86_64/usr/lib/python2.7/site-packages/setuptools_scm/utils.py:103: in function_has_arg
    argspec = inspect.getfullargspec(fn).args
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
func = <function parse_pkginfo at 0x7f7349f450c0>
    def getfullargspec(func):
        """Get the names and default values of a callable object's parameters.
    
        A tuple of seven things is returned:
        (args, varargs, varkw, defaults, kwonlyargs, kwonlydefaults, annotations).
        'args' is a list of the parameter names.
        'varargs' and 'varkw' are the names of the * and ** parameters or None.
        'defaults' is an n-tuple of the default values of the last n parameters.
        'kwonlyargs' is a list of keyword-only parameter names.
        'kwonlydefaults' is a dictionary mapping names from kwonlyargs to defaults.
        'annotations' is a dictionary mapping parameter names to annotations.
    
        .. deprecated:: 3.8
            Use inspect.signature() instead of inspect.getfullargspec().
    
        Notable differences from inspect.signature():
          - the "self" parameter is always reported, even for bound methods
          - wrapper chains defined by __wrapped__ *not* unwrapped automatically
        """
    
>       warnings.warn("Use inspect.signature() instead of inspect.getfullargspec()",
                      DeprecationWarning, stacklevel=2)
E       DeprecationWarning: Use inspect.signature() instead of inspect.getfullargspec()
/usr/lib64/python3.8/inspect.py:1114: DeprecationWarning
----------------------------- Captured stdout call -----------------------------
root '/builddir/build/BUILD/setuptools_scm-3.3.0'
root '/tmp/pytest-of-mockbuild/pytest-1/test_version_from_pkginfo0/wd'
root '/tmp/pytest-of-mockbuild/pytest-1/test_version_from_pkginfo0/wd'
looking for ep setuptools_scm.parse_scm /tmp/pytest-of-mockbuild/pytest-1/test_version_from_pkginfo0/wd
looking for ep setuptools_scm.parse_scm_fallback /tmp/pytest-of-mockbuild/pytest-1/test_version_from_pkginfo0/wd
found ep PKG-INFO = setuptools_scm.hacks:parse_pkginfo
@RonnyPfannschmidt
Copy link
Contributor

thanks for the note, this one an be fixed relatively painlessly
i'll try to get a fix out this evening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants