Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRETEND_VERSION_FOR_DIST_NAME does not work with setup.cfg #597

Closed
tomprince opened this issue Aug 2, 2021 · 4 comments · Fixed by #607
Closed

PRETEND_VERSION_FOR_DIST_NAME does not work with setup.cfg #597

tomprince opened this issue Aug 2, 2021 · 4 comments · Fixed by #607

Comments

@tomprince
Copy link

It appears that SETUPTOOLS_SCM_PRETEND_VERSION_FOR_DIST_NAME does not work when the dist name is in setup.cfg, since Distribution.finalize_options (which is where infer_version is hooked) is called before Distributionparse_config_files`.

@RonnyPfannschmidt
Copy link
Contributor

@jaraco i beleive tis is yet another setuptools issue thats hard to follow u with

@tomprince would it be reasonable enough for you if it still worked if use_scm_version was set in setup.py while this is being resolved

@jaraco
Copy link
Member

jaraco commented Aug 6, 2021

I commented on this in discord.

RonnyPfannschmidt added a commit to RonnyPfannschmidt/setuptools_scm that referenced this issue Aug 27, 2021
@tomprince
Copy link
Author

I've tested this against master, and it appears to work as expected. Thanks!

As an aside, I was a bit confused looking at the releases sidebar on https://github.com/pypa/setuptools_scm. It appears that there are newer releases on pypi (6.0.0 and 6.0.1) than are shown there. I guess if you've had any github releases, it will continue to show them, even if you stop using that feature. I'm not sure there is a good solution, though.

@RonnyPfannschmidt
Copy link
Contributor

@tomprince the releases where live and got yanked due to regressions that didn't show on our ci

i did have a facepalm friday with that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants