New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setuptools_scm silently reports garbage version with partial Git clone #790
Comments
there are some warnigns on shallw branches by default, its possible they gethidden can you show the output of |
we might want to involve readthedocs in this as well as its not clear to me off hand how to fix it for them |
@paugier I am not sure what you mean. The final successful rtd build reported the correct version number snek5000-0.8.0rc1.dev254+g7597f21 And there was no unshallow git operation. |
@ashwinvis I think this is because of the |
The output of
|
@paugier there is a warning about the worktree being shallow
i believe its necessary to provide some additional tooling to protect peopel from that trap without failing |
Based on the current details, I believe it's necessary to change the default from warning to failing on incomplete partial checkouts |
Fetch full history so that setuptools-scm could detect correct version For the context: - pypa/setuptools_scm#790 - https://docs.readthedocs.io/en/latest/build-customization.html#unshallow-git-clone
Readthedocs clones with
With such clone,
In contrast,
git tag
gives the right list of tags. Anyway, setuptools_scm bases its analysis ongit describe
so it gives a wrong version (something like0.1.dev173+g2a7b9f0
).To get the right version, I need to run:
I don't know what setuptools_scm could do about this case, but it is annoying. Maybe at least a warning?
CC @ashwinvis
The text was updated successfully, but these errors were encountered: