Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8.0.3 creates version file with unused Tuple import #932

Closed
jbezuk opened this issue Sep 22, 2023 · 2 comments · Fixed by #934
Closed

v8.0.3 creates version file with unused Tuple import #932

jbezuk opened this issue Sep 22, 2023 · 2 comments · Fixed by #934

Comments

@jbezuk
Copy link

jbezuk commented Sep 22, 2023

v8.0.2

# file generated by setuptools_scm
# don't change, don't track in version control
from __future__ import annotations

__version__ = version = '0.9.1.dev3+g150f74d'  # type: str
__version_tuple__ = version_tuple = (0, 9, 1, 'dev3', 'g150f74d')  # type: tuple[int | str, ...]

v8.0.3

# file generated by setuptools_scm
# don't change, don't track in version control
TYPE_CHECKING = False
if TYPE_CHECKING:
    from typing import Tuple

__version__ = version = '0.9.1.dev3+g150f74d'  # type: str
__version_tuple__ = version_tuple = (0, 9, 1, 'dev3', 'g150f74d')  # type: Tuple[int | str, ...]
@RonnyPfannschmidt
Copy link
Contributor

its needed for the type annotation in the comment - is it creating a inconvenience with a tool?

@jbezuk
Copy link
Author

jbezuk commented Sep 22, 2023

its needed for the type annotation in the comment - is it creating a inconvenience with a tool?

Hi Ronny, yes unfortunately we check our wheels for unused imports with flake8 before publishing (and do not publish them if they fail the check).

RonnyPfannschmidt added a commit to RonnyPfannschmidt/setuptools_scm that referenced this issue Sep 22, 2023
akx added a commit to akx/pytest-django that referenced this issue Sep 29, 2023
akx added a commit to akx/pytest-django that referenced this issue Sep 29, 2023
akx added a commit to akx/pytest-django that referenced this issue Sep 29, 2023
bluetech pushed a commit to pytest-dev/pytest-django that referenced this issue Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants