Add a "only-version" version scheme #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
thejcannon
commented
Jan 18, 2024
| @pytest.mark.parametrize( | ||
| "version", | ||
| [ | ||
| "1.dev0", |
There was a problem hiding this comment.
Ripped from https://peps.python.org/pep-0440/
RonnyPfannschmidt
approved these changes
Jan 19, 2024
…tools_scm into jcannon/fix1002
for more information, see https://pre-commit.ci
…tools_scm into jcannon/fix1002
|
Done and done. |
|
thanks, would you like to see this squashed or should i merge as is? |
|
Oh I'm definitely camp squash-merge. "Rename" isn't much of an inspiring commit message 😂 |
thejcannon
changed the title
|
@RonnyPfannschmidt when might there be a new version of Thanks! 🙏 |
|
I'll try to merge the clean up mr soon and releas this week |
|
Here's a bump on getting that release up and going as I'd like to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1002 by adding a "only-version" version scheme.