Prefer to only use 'git describe' for all required info #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the reason was #86 - as git describe is failing with no tags present or no commits present |
|
Ok, but in that case the fallback should kick in, and all is good, or? |
|
@sschuberth yes, i just finished crosschecking, and your adaption is more nice as its faster in all usually relevant cases |
|
@sschuberth please add a change-log entry, then i can merge, good work 👍 |
|
For which version? 1.15.1 still? |
|
yup |
Previously, three git commands were used to gather all required info. Now all info is gathered from a single 'git describe' call in all usual cases, and only if that fails fallbacks are used. The --dirty option was already present before commit 929a5d7, but it was removed to address [1], which turns out to not actually be necessary as we can try "git describe --dirty" first and then eventually use the fallback. [1] #86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, three git commands were used to gather all required info.
Now all info is gathered from a single 'git describe' call and only if
that fails fallbacks are used.
There already was the --dirty option before commit 929a5d7, but no
reason was given why it was removed.