Share the stderr with the user, when non-zero exit code #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to non-zero exit code.
for more information, see https://pre-commit.ci
src/setuptools_scm/_run_cmd.py
Outdated
| if not res and not message: | ||
| message = p.stderr | ||
|
|
||
| return Result(status=res, message=message) |
There was a problem hiding this comment.
lets define the Result class in the same module as its only used for this particular function
it mgiht make sense to use the logging based output in any case (when has command initially was created, warnings was used as trace was only opt in by env var
now with the logging setup that chooses level, we can just log a error directly
There was a problem hiding this comment.
You are very fast to reply! Thank you. 😄
Just logging directly would indeed more straight forward. That will remove the need to return a complex type from has_command, so I can just skip the result wrapper entirely. I'll rework the PR.
added 5 commits
September 21, 2023 14:53
|
The diff is a bit smaller now, and there is a test. 😄 |
|
Want to squash? |
Yes please! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a has_command() returns False, we eat all the output and just say that it was not found. In case the False return is due to a non-zero exit status from a command we did actually find, this makes it quite messy to figure out what went wrong.
This is an attempt to let output from the failing command bubble up the stack, with a minimal amount of disruption to surrounding code.