Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requires #955

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Update requires #955

merged 1 commit into from
Oct 17, 2023

Conversation

jaap3
Copy link
Contributor

@jaap3 jaap3 commented Oct 10, 2023

Noticed the requires line in usage.md and README.md was inconsistent with how it was specified elsewhere (customizing.md and index.md).

@jaap3 jaap3 marked this pull request as ready for review October 10, 2023 14:01
@jaap3
Copy link
Contributor Author

jaap3 commented Oct 10, 2023

Didn't see this before creating this PR: #921 is an issue about the inconsistency in the docs

@RonnyPfannschmidt
Copy link
Contributor

lets use the examples from https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html as base

for safety the backend needs to be added, wheel is auto-added these days by setuptools internals

Copy link
Contributor

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, thanks 👍

@jaap3
Copy link
Contributor Author

jaap3 commented Oct 11, 2023

@RonnyPfannschmidt I've updated the PR. Not 100% sure I understood what you meant so I hope it's alright :)

There's still a small inconsistency with the minimum setuptools required. The examples now all say >=64, but the text and the setuptools integration check say >=61.

@RonnyPfannschmidt RonnyPfannschmidt merged commit 529d5bb into pypa:main Oct 17, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants