Documenting SETUPTOOLS_SCM_PRETEND_VERSION_FOR_${NORMALIZED_DIST_NAME}
#981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbraza
commented
Nov 20, 2023
| in which case it will be an unparsed string | ||
| : used as the primary source for the version number, | ||
| in which case it will be an unparsed string. | ||
| Specifying distribution-specific pretend versions will |
There was a problem hiding this comment.
Can I say something like "distribution-specific (aka package-specific)"
There was a problem hiding this comment.
I'm wondering if it perhaps should change to python package name to disambiguate
There was a problem hiding this comment.
for parity, as a followup
There was a problem hiding this comment.
I finally got around to this today, and concluded:
- The term "distribution" is all over the Python docs (e.g.
importlib.metadata, legacy install docs,setuptoolsdocs) - "dist" is also all over the place in the source code here
So I think it's fine to stick with the terminology "distribution" here after all. I am going to skip on opening a PR to change the wording from "dist" to "pkg"
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #978