Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanups + bugfixes #996

Merged
merged 18 commits into from
Feb 15, 2024
Merged

Conversation

@eachimei
Copy link

eachimei commented Jan 5, 2024

@RonnyPfannschmidt please kindly note that in git.py in run_git there's currently a default value to timeout: int = 20. As a result, the changes of BROKEN_TIMEOUT (env var override) won't take effect.
Also, in fetch_shallow() a timeout value of 240 is passed into run_git call so if the user overrides the env-var it won't impact this subprocess call.

@RonnyPfannschmidt
Copy link
Contributor Author

thanks for the note, - i completely missed that detail - i'll integrate the none pass-over there as well

@RonnyPfannschmidt
Copy link
Contributor Author

i'll leave the timeout i fetch shallow for now as its intentional as is and the delay should work as intended for now

its not used by default and i'll start to recommend people prepare unshallow in ci instead of adding the setting to setuptools_scm

@eachimei
Copy link

eachimei commented Jan 8, 2024

alright, sounds good 👍

@RonnyPfannschmidt RonnyPfannschmidt force-pushed the ronny/cleanups branch 2 times, most recently from 1ae2ec1 to 9af3ba4 Compare January 8, 2024 13:28
@RonnyPfannschmidt RonnyPfannschmidt merged commit d9b3b29 into pypa:main Feb 15, 2024
18 checks passed
@RonnyPfannschmidt RonnyPfannschmidt deleted the ronny/cleanups branch February 15, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants