You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
How did you install twine? Did you use your operating system's package manager or pip or something else?
pip
Version of twine you have installed (include complete output of):
1.12.1
The Issue
Please describe the issue that you are experiencing.
Twine is unconditionally importing readme_renderer.markdown but is not depending on readme_renderer[md], thus triggering a UserWarning when twine check is executed.
Steps to Reproduce
run twine check and observe
/path/to/virtualenv/lib/python3.6/site-packages/readme_renderer/markdown.py:38: UserWarning: Markdown renderers are not available. Install 'readme_render[md]' to enable Markdown rendering.
warnings.warn(_EXTRA_WARNING)
Proposed fix
Do not import readme_renderer.markdown unless the content-type text/markdown is found. Then when validation fails the user sees the warning and knows they need to install the extra dependency.
macOS 10.14
3.7.0
pip
1.12.1
The Issue
Please describe the issue that you are experiencing.
Twine is unconditionally importing
readme_renderer.markdown
but is not depending onreadme_renderer[md]
, thus triggering aUserWarning
whentwine check
is executed.Steps to Reproduce
run
twine check
and observeProposed fix
Do not import
readme_renderer.markdown
unless the content-typetext/markdown
is found. Then when validation fails the user sees the warning and knows they need to install the extra dependency.twine/twine/commands/check.py
Line 27 in bd1d8b0
The text was updated successfully, but these errors were encountered: