Can't use a password if client certificate is used

[future-cyborg]

Bug introduced by #483

I'm trying to upload to a private pypi server. There is a client-certificate SSL reverse proxy in front, and the pypi server has user authentication.

I used to be able to have both of these, but I can't upload anymore since #483.

Looking at #336, I don't think any code change was necessary. Now that the --non-interactive option is available.

Can #483 be reverted please?

[bhrutledge]

@future-cyborg Is this still an issue for you?

@jaraco I think you're closer to the details here; do you have any suggestions?

[jaraco]

Thanks for reporting the issue.

Looking at #336, I don't think any code change was necessary. Now that the --non-interactive option is available.

That's interesting. Looks like --non-interactive was introduced in 3.0.

Can #483 be reverted please?

Even if it can be reverted, it shouldn't be summarily reverted. It's important in situations like these to capture all of the requirements in tests. The fact that OP relied on the ability to supply both a password and a client cert was not captured by the tests, which is why this regression in behavior was allowed to occur.

What this project needs instead is a new test on top of the tests added in #483 (possibly tweaked) to capture the desired behavior that captures all of the supported use-cases.

@future-cyborg Would you be willing to put together a pull request that accomplishes that task? And let's try to get the reporters of #336 to confirm that --non-interactive works for their use-case once password support can be disentangled from client cert behavior.

[future-cyborg]

Yes, this is still an issue. I've pinned to earlier version to get my functionality.

Yes, I can put together a PR for this. I'll take a look at the the tests cases and see what we can add.