Fix download is True by default

Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
pypa · May 4, 2020 · 0bb7269 · 0bb7269
1 parent 73793c7
commit 0bb7269
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 7 deletions.
diff --git a/src/virtualenv/seed/embed/base_embed.py b/src/virtualenv/seed/embed/base_embed.py
@@ -45,13 +45,6 @@ def package_version(self):
     @classmethod
     def add_parser_arguments(cls, parser, interpreter, app_data):
         group = parser.add_mutually_exclusive_group()
-        group.add_argument(
-            "--download",
-            dest="download",
-            action="store_true",
-            help="pass to enable download of the latest {} from PyPI".format("/".join(cls.packages)),
-            default=False,
-        )
         group.add_argument(
             "--no-download",
             "--never-download",
@@ -60,6 +53,13 @@ def add_parser_arguments(cls, parser, interpreter, app_data):
             help="pass to disable download of the latest {} from PyPI".format("/".join(cls.packages)),
             default=True,
         )
+        group.add_argument(
+            "--download",
+            dest="download",
+            action="store_true",
+            help="pass to enable download of the latest {} from PyPI".format("/".join(cls.packages)),
+            default=False,
+        )
         parser.add_argument(
             "--extra-search-dir",
             metavar="d",

diff --git a/tests/unit/seed/test_base_embed.py b/tests/unit/seed/test_base_embed.py
@@ -0,0 +1,11 @@
+import pytest
+
+from virtualenv.run import session_via_cli
+
+
+@pytest.mark.parametrize(
+    "args, download", [([], False), (["--no-download"], False), (["--never-download"], False), (["--download"], True)]
+)
+def test_download_cli_flag(args, download, tmp_path):
+    session = session_via_cli(args + [str(tmp_path)])
+    assert session.seeder.download is download