Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating virtualenvs from a virtualenv always yells at me #1193

Closed
Julian opened this issue Jul 17, 2018 · 4 comments
Closed

Creating virtualenvs from a virtualenv always yells at me #1193

Julian opened this issue Jul 17, 2018 · 4 comments

Comments

@Julian
Copy link

Julian commented Jul 17, 2018

Creating a virtualenv from within a virtualenv (on PyPy only?) always spits out spurious Path not in prefix warnings, that appear to come from https://github.com/pypa/virtualenv/blob/master/virtualenv.py#L1087.

Functionally, everything appears fine, and from reading the surrounding code their quickly, it seems like the warning is incorrect in this case (and that the next block of code is going to find the correct value), but it's difficult to tell.

Reproducer:

~/Desktop
⊙  rm -rf foo bar && pypy ~/Development/virtualenv/virtualenv.py --quiet foo && echo "DONE" && foo/bin/pypy ~/Development/virtualenv/virtualenv.py --quiet bar                                                                                                                                                                                              Julian@Macnetic
DONE
Path not in prefix '/Users/Julian/Desktop/foo/include' '/usr/local/Cellar/pypy/6.0.0/libexec'
@gaborbernat
Copy link
Contributor

@Julian can you provide a test that exhibits this as a PR?

@stale
Copy link

stale bot commented Apr 14, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Just add a comment if you want to keep it open. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 14, 2019
@Julian
Copy link
Author

Julian commented Apr 14, 2019

Missed that comment but yeah sure could probably turn that bash into a test fairly easily.

@gaborbernat
Copy link
Contributor

This is becoming obsolete with #1366 now in full swing.

@Julian Julian removed their assignment Mar 11, 2020
inducer added a commit to inducer/ci-support that referenced this issue Jul 14, 2020
@pypa pypa locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants