Creating virtualenvs with PyPy always warns about a missing LICENSE file

[Julian]

⊙  pypy ~/Development/virtualenv/virtualenv.py --quiet foo                                                                     jberman@USNYHJBERMANMB2
  No LICENSE.txt / LICENSE found in source

virtualenv/virtualenv.py

Line 1321 in 5e3a70c

os.path.join(prefix, "LICENSE"),

looks like the problematic line, introduced in #1318.

The license() builtin in PyPy is static, and doesn't have a LICENSE to copy.

[asottile]

This seems specific to pypy installed via homebrew, we should be able to retrieve the LICENSE file there as well:

#1318 (comment)

[m1keil]

also seem to happen on my fedora 30 install.
using system python with virtualenv installed with --user.

[asottile]

@m1keil I assume that's pypy packaged by fedora? is there a LICENSE in any of the files that get installed?

[m1keil]

sorry for the mix up. This actually happens with the regular system pip and python for me.

$ which virtualenv
~/.local/bin/virtualenv

$ virtualenv --version
16.6.0

$ virtualenv -p /usr/bin/python3 test
Using base prefix '/usr'
  No LICENSE.txt / LICENSE found in source
New python executable in /tmp/tmp.pVP6AhACXo/test/bin/python3
Also creating executable in /tmp/tmp.pVP6AhACXo/test/bin/python
Installing setuptools, pip, wheel...
done.

$ rpm -ql python3 | grep LICENSE
/usr/share/licenses/python3/LICENSE

$ rpm -ql python3-pip | grep LICENSE
/usr/lib/python3.7/site-packages/pip-19.0.3.dist-info/LICENSE.txt
/usr/share/licenses/python3-pip/LICENSE.txt

[gaborbernat]

@asottile so did we fix this then?

[asottile]

We did not, I vote just deleting the warning since it seems inconsistent where packagers chose to move the README and in some cases it is completely missing

[hroncok]

All the Pythons distributed with Fedora have this warning. We have the LICENSE file in /usr/share/licenses/python3/LICENSE - I wonder whether this needs to be fixed.

[hroncok]

OK, we shall fix this... https://src.fedoraproject.org/rpms/python38/pull-request/33

[hroncok]

Weirdly, even if /usr/lib64/python3.8/LICENSE.txt is present and the license() on python3.8 shows it, virtualenv still warns:

$ virtualenv -p python3.8 py38
Running virtualenv with interpreter /usr/bin/python3.8
Already using interpreter /usr/bin/python3.8
Using base prefix '/usr'
  No LICENSE.txt / LICENSE found in source
...

[asottile]

@hroncok weird, what does this resolve to for fedora pythons?

virtualenv/virtualenv.py

Line 1338 in d997faa

os.path.join(prefix, os.path.relpath(lib_dir, dst_prefix), "LICENSE.txt"),

[hroncok]

/usr/lib/python3.8/LICENSE.txt

We have lib64 (on 64bit arches).

[hroncok]

I'll send a PR.