Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration with virtualenvwrapper #1508

Closed
matthew-brett opened this issue Jan 28, 2020 · 3 comments
Closed

Integration with virtualenvwrapper #1508

matthew-brett opened this issue Jan 28, 2020 · 3 comments

Comments

@matthew-brett
Copy link

Congratulations on the rewrite.

I notice that virtualenvwrapper doesn't integrate with the new beta:

$ mkvirtualenv foo
ERROR: Environment '/Users/brettmz/.virtualenvs/foo' does not contain an activate script.

Sure enough - I believe it is looking for a script activate - but the script file now depends on the shell - activate.sh etc.

It would be good if this could work somehow - would it be reasonable to create / link a default activate script for this case? Or should virtualenvwrapper be updated?
@gaborbernat
Copy link
Contributor

This seems an oversight on our side, indeed should be just activate not activate.sh.

@gaborbernat gaborbernat mentioned this issue Jan 28, 2020
Merged
gaborbernat added a commit to gaborbernat/virtualenv that referenced this issue Jan 28, 2020
@gaborbernat
Bash activator should have no extension pypa#1508
11b42fa 
This is how things worked without the rewrite and in
venv so consolidating.

Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
gaborbernat added a commit to gaborbernat/virtualenv that referenced this issue Jan 28, 2020
@gaborbernat
Bash activator should have no extension pypa#1508
f4a3435 
This is how things worked without the rewrite and in
venv so consolidating.

Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
gaborbernat added a commit that referenced this issue Jan 28, 2020
@gaborbernat
Bash activator should have no extension #1508 (#1509)
0f6d7de 
This is how things worked without the rewrite and in
venv so consolidating.

Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat
Copy link
Contributor

Resolved in #1509

@matthew-brett
Copy link
Author

Excellent - thanks.

@gaborbernat gaborbernat mentioned this issue Jan 29, 2020
Closed
@pypa pypa locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matthew-brett @gaborbernat