Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with virtualenvwrapper #1508

Closed
matthew-brett opened this issue Jan 28, 2020 · 3 comments
Closed

Integration with virtualenvwrapper #1508

matthew-brett opened this issue Jan 28, 2020 · 3 comments

Comments

@matthew-brett
Copy link

@matthew-brett matthew-brett commented Jan 28, 2020

Congratulations on the rewrite.

I notice that virtualenvwrapper doesn't integrate with the new beta:

$ mkvirtualenv foo
ERROR: Environment '/Users/brettmz/.virtualenvs/foo' does not contain an activate script.

Sure enough - I believe it is looking for a script activate - but the script file now depends on the shell - activate.sh etc.

It would be good if this could work somehow - would it be reasonable to create / link a default activate script for this case? Or should virtualenvwrapper be updated?

@gaborbernat

This comment has been minimized.

Copy link
Contributor

@gaborbernat gaborbernat commented Jan 28, 2020

This seems an oversight on our side, indeed should be just activate not activate.sh.

gaborbernat added a commit to gaborbernat/virtualenv that referenced this issue Jan 28, 2020
This is how things worked without the rewrite and in
venv so consolidating.

Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
gaborbernat added a commit to gaborbernat/virtualenv that referenced this issue Jan 28, 2020
This is how things worked without the rewrite and in
venv so consolidating.

Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
gaborbernat added a commit that referenced this issue Jan 28, 2020
This is how things worked without the rewrite and in
venv so consolidating.

Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat

This comment has been minimized.

Copy link
Contributor

@gaborbernat gaborbernat commented Jan 28, 2020

Resolved in #1509

@matthew-brett

This comment has been minimized.

Copy link
Author

@matthew-brett matthew-brett commented Jan 28, 2020

Excellent - thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.