Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document not supporting pre PEP-518 build systems and suggest workarounds #1619

Closed
gaborbernat opened this issue Feb 14, 2020 · 5 comments
Closed
Labels

Comments

@gaborbernat
Copy link
Contributor

@gaborbernat gaborbernat commented Feb 14, 2020

Though we don't support setup.py bdist_wheel we should mention that if one ensures build-requires are present things "should work". But in such cases, the responsibility falls onto whoever does the build to ensure pyproject.toml is kept in sync with such dependencies.

@shankarj67

This comment has been minimized.

Copy link

@shankarj67 shankarj67 commented Mar 5, 2020

Can I work on this issue?

@gaborbernat

This comment has been minimized.

Copy link
Contributor Author

@gaborbernat gaborbernat commented Mar 6, 2020

For sure 👍

@shankarj67

This comment has been minimized.

Copy link

@shankarj67 shankarj67 commented Mar 6, 2020

Can you provide some pointers to what exactly I have to do?

@gaborbernat

This comment has been minimized.

Copy link
Contributor Author

@gaborbernat gaborbernat commented Mar 6, 2020

@shankarj67 sorry this is not a good first issue if you're not familiar with PEP-517/518 and the ecosystem; writing down the pointers is exactly the scope of this issue 👍

gaborbernat added a commit to gaborbernat/virtualenv that referenced this issue Mar 10, 2020
Resolves pypa#1618.
Resolves pypa#1619.
Resolves pypa#1620.

Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
gaborbernat added a commit that referenced this issue Mar 10, 2020
Resolves #1618.
Resolves #1619.
Resolves #1620.

Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat

This comment has been minimized.

Copy link
Contributor Author

@gaborbernat gaborbernat commented Mar 10, 2020

Hello, a fix for this issue has been released via virtualenv 20.0.10; see https://pypi.org/project/virtualenv/20.0.10/ (https://virtualenv.pypa.io/en/latest/changelog.html#v20-0-10-2020-03-10). Please give a try and report back if your issue has not been addressed; if not, please comment here, and we'll reopen the ticket. We want to apologize for the inconvenience this has caused you and say thanks for having patience while we resolve the unexpected bugs with this new major release.
thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.