Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdist is missing tasks/make_zipapp.py #2610

Closed
mtelka opened this issue Jul 19, 2023 · 3 comments
Closed

sdist is missing tasks/make_zipapp.py #2610

mtelka opened this issue Jul 19, 2023 · 3 comments

Comments

@mtelka
Copy link
Contributor

mtelka commented Jul 19, 2023

The sdist package at PyPI is missing tasks/make_zipapp.py file. Without the file following three tests fails:

=========================== short test summary info ============================
ERROR tests/integration/test_zipapp.py::test_zipapp_help - subprocess.CalledP...
ERROR tests/integration/test_zipapp.py::test_zipapp_create[app-data] - subpro...
ERROR tests/integration/test_zipapp.py::test_zipapp_create[pip] - subprocess....
===== 351 passed, 21 skipped, 103 warnings, 3 errors in 452.91s (0:07:32) ======

Please add missing tasks/make_zipapp.py to sdist.

Thank you.

@mtelka mtelka added the bug label Jul 19, 2023
@mtelka
Copy link
Contributor Author

mtelka commented Jul 19, 2023

To get all tests passed we need also tasks/__main__zipapp.py.

@sigma67
Copy link
Contributor

sigma67 commented Aug 9, 2023

I take it all scripts in tasks should be included in sdist?

@mtelka
Copy link
Contributor Author

mtelka commented Aug 9, 2023

For virtualenv-20.24.0 I just needed to add tasks/make_zipapp.py and tasks/__main__zipapp.py to see all tests passed. So I believe the other three files there are not needed for testing. But it shouldn't hurt if they are included in the sdist IMHO.

sigma67 added a commit to sigma67/virtualenv that referenced this issue Aug 10, 2023
gaborbernat pushed a commit that referenced this issue Aug 11, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@mtelka mtelka closed this as completed Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants