Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: remove py33 and added py36 #1089

Merged
merged 1 commit into from Oct 6, 2017
Merged

Conversation

ssbarnea
Copy link
Contributor

@ssbarnea ssbarnea commented Oct 4, 2017

py33 reached EOL and the Travis version is broken
as it missing zlib encoder, making impossible
to test bin/build_script.py

py33 reached EOL and the Travis version is broken
as it missing zlib encoder, making impossible
to run bin/build_script.py
py36 is officially released on all platform so
we need to test with it.
Copy link

@jakub-bochenski jakub-bochenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for linking to the source document

@dstufft dstufft merged commit f63a574 into pypa:master Oct 6, 2017
@ssbarnea
Copy link
Contributor Author

ssbarnea commented Oct 6, 2017

@dstufft and @jakub-bochenski - Thank you! Remind me to buy a beer when we meet.

As expected, now the #1087 is passing.

@agronholm
Copy link

Python 2.6 has reached EOL 4 years ago. Why was that still left in?

@ssbarnea
Copy link
Contributor Author

ssbarnea commented Oct 7, 2017

@agronholm You are right but I would avoid removing it unless we found something broken with it. Usually you drop support when you cannot support it anymore not for the sake of it.

As currently the few tests that we have are passing on py26, I see no reason to drop. If they will find a bug that we can avoid inside virtualenv we will keep it. Once we discover that there is no way to keep supporting py26, we will drop it.

py33 on Travis was such an example, as it missing the zlib library and nobody is going to ever add it to py33. So is was more of being forced to drop support for it than just doing it.

@dstufft
Copy link
Member

dstufft commented Oct 7, 2017

Python 2.6 isn't supported in pip anymore, so when I pull in the next version of pip into virtualenv I'll end up dropping py26 anyways.

@ssbarnea
Copy link
Contributor Author

ssbarnea commented Oct 7, 2017

@dstufft I doubt many will cry when you will do this. I woudnt for sure, I was dreaming about getting pip >= 9 wide spread. The doctor feauture is very useful.

This was referenced Jan 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants