Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add zipapp support with bundled dependencies #1491

Merged
merged 1 commit into from Jan 16, 2020

Conversation

gaborbernat
Copy link
Contributor

@gaborbernat gaborbernat commented Jan 10, 2020

Will resolve #1464.

Creates a zipapp that has all dependencies (for all platforms), using the python2.7 dependency versions and validate these provide the same functionality as one would install into a python.

dependencies:
appdirs-1.4.3-py2.py3-none-any.whl
importlib_metadata-1.4.0-py2.py3-none-any.whl
importlib_resources-1.0.2-py2.py3-none-any.whl
more_itertools-5.0.0-py2-none-any.whl
pathlib2-2.3.5-py2.py3-none-any.whl
six-1.13.0-py2.py3-none-any.whl
zipp-0.6.0-py2.py3-none-any.whl
distlib-0.3.0-py3-none-any.whl
virtualenv-0.1.dev39+gf3036b8.d20200113-py2.py3-none-any.whl
zipapp created at virtualenv.pyz

Maybe we should pin these version 🤔 Down the line we might have some dynamic way of selecting the correct library version, but for now, 2.7 versions handles all 3 too...

@gaborbernat gaborbernat added this to the 20.0.0 milestone Jan 13, 2020
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat
Copy link
Contributor Author

Finally, that works on all platforms!

finally

@gaborbernat gaborbernat merged commit b5f618f into pypa:rewrite Jan 16, 2020
@gaborbernat gaborbernat deleted the zipapp branch January 16, 2020 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants