Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtualenv fish shell bgcolor to black #785

Closed
wants to merge 1 commit into from
Closed

virtualenv fish shell bgcolor to black #785

wants to merge 1 commit into from

Conversation

AndreasHassing
Copy link

White on blue in fish shell is extremely unreadable - not sure if this is just the case for my particular installation, but this seems to look better.

White on blue in fish shell is extremely unreadable - not sure if this is just the case for my particular installation, but this seems to look better.
@Ivoz
Copy link

Ivoz commented Sep 19, 2015

Hi there @AndreasHassing , you never supplied the source file of the change (in virtualenv_embedded/activate.fish)

@AndreasHassing
Copy link
Author

Oh yeah @Ivoz, thanks for pointing it out to me. I'll fix it once I'm back on the laptop and notify you.

@Ivoz
Copy link

Ivoz commented Sep 20, 2015

Also note activate.fish was updated recently, you may have to rebase changes.

@Ivoz
Copy link

Ivoz commented Sep 20, 2015

@AndreasHassing I changed the format to be hopefully more sensible in 22d7773 maybe that might suite the needs of this PR?

@Ivoz Ivoz force-pushed the develop branch 2 times, most recently from d33e617 to 1682ed6 Compare September 20, 2015 16:57
@Ivoz
Copy link

Ivoz commented Oct 3, 2015

I'm hoping the current code when released will look ok (better than last release). Thanks for suggesting it get improved and your contribution anyway. If you think it could still use help next release please do yell :)

@Ivoz Ivoz closed this Oct 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants