Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a SMTP service for development #2709

Merged
merged 5 commits into from
Jan 2, 2018
Merged

Add a SMTP service for development #2709

merged 5 commits into from
Jan 2, 2018

Conversation

di
Copy link
Member

@di di commented Dec 28, 2017

This adds a SMTP service which prints the contents of any email sent to it to stdout, and configures it to be our SMTP server in development.

Previously pyramid_mailer.debug was writing each email to disk on the worker service, which was tedious to use.

I opted to roll our own DebuggingServer because by default, our emails are quoteable-printed encoded, but smtpd.DebuggingServer doesn't decode them before printing, so links and such are hard to use.

Copy link
Member

@ewdurbin ewdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems sound.

at some point down the line we may want to keep recent emails in the DB for administrator viewing as well as deliverability analysis (many MTA services provide hooks now adays).

if we ever do this, the dev service could just be a null op that writes to the DB but does not send.

@di di merged commit 54de4ba into pypi:master Jan 2, 2018
@di di deleted the smtp-service branch January 2, 2018 15:52
@di di mentioned this pull request Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants