Add project.last_serial to simple.detail and legacy.api.json routes #3429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the project's latest serial to `/simple/<project_name>/` and `/pypi/<project_name>/json`. As Warehouse uses Fastly Soft Purges, we need to tweak the ETag in order to notify the CDN that the page has changed. Currently the CDN performs a conditional GET in order to decide if it needs to pull refreshed content, and since the contents of these pages don't change for maintainer and role updates it skips purging them. This is primarily a concern for clients like bandersnatch which use the X-PyPI-Last-Serial header to determine if they're getting the latest goods.
dstufft
reviewed
Mar 26, 2018
warehouse/legacy/api/json.py
Outdated
| @@ -186,6 +186,7 @@ def json_release(release, request): | |||
| "bugtrack_url": project.bugtrack_url, | |||
| "home_page": release.home_page, | |||
| "download_url": release.download_url, | |||
| "last_serial": project.last_serial, | |||
There was a problem hiding this comment.
This should probably be a top level key, it's not part of the release info.
dstufft
approved these changes
Mar 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the project's latest serial to
/simple/<project_name>/and/pypi/<project_name>/json.As Warehouse uses Fastly Soft Purges, we need to tweak the ETag in order to notify the CDN that the page has changed. Currently the CDN performs a conditional GET in order to decide if it needs to pull refreshed content, and since the contents of these pages don't change for maintainer and role updates it skips purging them.
This is primarily a concern for clients like bandersnatch which use the X-PyPI-Last-Serial header to determine if they're getting the latest goods.