Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark required fields #6370

Merged
merged 3 commits into from
Aug 8, 2019
Merged

Mark required fields #6370

merged 3 commits into from
Aug 8, 2019

Conversation

nlhkabu
Copy link
Contributor

@nlhkabu nlhkabu commented Aug 6, 2019

Closes #6281
Screenshot from 2019-08-06 06-50-30

@nlhkabu nlhkabu requested a review from woodruffw August 6, 2019 05:51
@di
Copy link
Member

di commented Aug 6, 2019

I think it might be better to add something like:

{% if field.flags.required %}(Required){% endif %}

to every field, so this happens automatically instead of having to be done manually.

Might make sense to use a macro to render a field in a consistent way so we only have to do this in one place, but that would also require figuring out where to set the human-readable field name, and doing it for all the fields.

@nlhkabu
Copy link
Contributor Author

nlhkabu commented Aug 8, 2019

Hi @di, @woodruffw - I've updated this PR to use field.flags.required as suggested, and opened a ticket for creating a field macro here: #6393

@di di force-pushed the 6281-form-label-accessibility branch from e8a22a2 to 253c4c0 Compare August 8, 2019 14:17
@di di mentioned this pull request Aug 8, 2019
@di di merged commit 37c2e18 into master Aug 8, 2019
@di di deleted the 6281-form-label-accessibility branch August 8, 2019 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update form labels to reflect required status and format requirements
2 participants