Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use default macos/arm64 deployment target in calculating the platform tag for fat binaries #390

Merged
merged 1 commit into from
Dec 13, 2020

Conversation

ronaldoussoren
Copy link
Contributor

The system compiler in Xcode 12 will not set the deployment target for arm64 below 11.0.0
(which is the first version of macOS supporting arm64). To allow building wheels that target
an earlier version of macOS (by way of the x86_64 part of fat binaries) ignore the deployment
target in the arm64 part of fat binaries when that's 11.0.0.

This fixes #387

…atform tag for fat binaries

The system compiler in Xcode 12 will not set the deployment target for arm64 below 11.0.0
(which is the first version of macOS supporting arm64). To allow building wheels that target
an earlier version of macOS (by way of the x86_64 part of fat binaries) ignore the deployment
target in the arm64 part of fat binaries when that's 11.0.0.
@ronaldoussoren
Copy link
Contributor Author

With this PR it is possible to create wheels targeting the "universal2" installer on Python.org (introduced for Python 3.9.1, and likely the only installer variant for 3.10).

The PR should not allow creating wheels that won't work on the macOS version specified in the platform tag: The version in the tag can be lower than 11.0.0, but only when the arm64 part of the binary works on macOS 11.0.0 which is the lowest version of macOS that supports arm64.

@agronholm agronholm merged commit a717e52 into pypa:master Dec 13, 2020
@agronholm
Copy link
Contributor

Thanks!

@ronaldoussoren
Copy link
Contributor Author

Thanks for the quick response.

Can you give an indication when this will end up in a release?

@agronholm
Copy link
Contributor

I expect to make a new release today or tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong platform tag for wheel build on macOS 11 with universal2 installer
2 participants