Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.12 support #517

Closed
nijel opened this issue Nov 6, 2023 · 3 comments · Fixed by #518
Closed

Python 3.12 support #517

nijel opened this issue Nov 6, 2023 · 3 comments · Fixed by #518

Comments

@nijel
Copy link
Contributor

nijel commented Nov 6, 2023

Is Python 3.12 supported or are there some known issues? I see the CI tests are not executed with Python 3.12, so it might be useful to add.

I'm asking because our code using on pyparsing is failing on Python 3.12 (see translate/translate#5071). It might be as well bug on our side, but before digging into that, I'd like to know whether it is expected to work or not.

@ptmcg
Copy link
Member

ptmcg commented Nov 6, 2023

My expectation is that pyparsing should be compatible with Python 3.12. I'm not aware of any breaking changes in 3.12 that would affect pyparsing. Nor am I aware of any changes in 3.12 that would change how pyparsing performs its parsing and returns the constructed ParseResults.

Can you distill this down to a smaller repro case?

I do include 3.12 in the list of versions in tox.ini, and in the list of classifiers in pyproject.toml. Can you show me where the CI tests don't run 3.12, so I can make the necessary changes to add it?

@nijel
Copy link
Contributor Author

nijel commented Nov 6, 2023

Yes, I will get to it later this week. I just wanted to make sure I'm not figuring out a known issue in case there is one 😄.

@nijel
Copy link
Contributor Author

nijel commented Nov 7, 2023

Okay, our test failure turns out to be unrelated to pyparsing, I apologize for the confusion. Somehow a general bug was triggered only in code-path which is the only one using pyparsing, so I was looking for a problem here…

nijel added a commit to nijel/pyparsing that referenced this issue Nov 7, 2023
@ptmcg ptmcg closed this as completed in #518 Nov 7, 2023
ptmcg pushed a commit that referenced this issue Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants