Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: More specific error in burnins script #4026

Merged
merged 2 commits into from Oct 25, 2022

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Oct 25, 2022

Brief description

Raise more specific error in burnins script when input does not have streams before otio ffprobe is called.

Description

It would crash anyway but with cryptic error that subprocess failed to run in otio adapters. This can happen when input does not have any streams (invalid movie file).

Additional information

Not sure how the movie file can be invalid (seems like skip-handles tag on single frame can cause it?). Issue created #4028

Testing notes:

  1. Invalid input movie file in burnins should cause error with more specific information.

@iLLiCiTiT iLLiCiTiT self-assigned this Oct 25, 2022
@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label Oct 25, 2022
Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error output is more informative

image

@iLLiCiTiT iLLiCiTiT merged commit 24b4397 into develop Oct 25, 2022
@iLLiCiTiT iLLiCiTiT deleted the feature/more_specific_burnin_error branch October 25, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants