Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Oiio conversion multipart fix #4060

Merged
merged 7 commits into from Dec 6, 2022

Conversation

iLLiCiTiT
Copy link
Member

Brief description

Don't define input channels if input is multipart exr.

Description

When converting multipart exr for ffmpeg it can't handle definition of channels on input because there are multiple subimages which cause crash if oiiotool.

Extended few types in xml info result parsing and added ability to receive information about every subimage in exr.

Additional information

The output has all subimages (which can be big exr) that is because ffmpeg then created transparent image without any content. Not sure why but it's an issue. Also if any subimage in the exr has attributes with invalid characters or too long value it would cause issues in ffmpeg too -> future enhancements.

Testing notes:

  1. It should be possible to convert multipart exr for ffmpeg (e.g. in extract review)

@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label Nov 2, 2022
@iLLiCiTiT iLLiCiTiT self-assigned this Nov 2, 2022
@github-actions github-actions bot added this to the next-patch milestone Nov 2, 2022
@jakubjezek001 jakubjezek001 removed this from the next-patch milestone Nov 10, 2022
@antirotor
Copy link
Member

Looks good but since we are messing up now with xml, shouldn't we parse it and work with it that way instead of hacking it as string?

@iLLiCiTiT
Copy link
Member Author

Looks good but since we are messing up now with xml, shouldn't we parse it and work with it that way instead of hacking it as string?

I don't know to which code is this related?

@LiborBatek
Copy link
Member

LiborBatek commented Nov 16, 2022

Did test in maya2022 and arnold with Multipart and Merge AOVs
Deadline job finnished normally without any errors and published all assets

here is the scrncap of published data
image

however when played the mp4 review even thumbnail looked fine the vid is completely black...
image

@antirotor
Copy link
Member

Looks good but since we are messing up now with xml, shouldn't we parse it and work with it that way instead of hacking it as string?

I don't know to which code is this related?

all lines like if line == "</ImageSpec>": - wouldn't be cleaner to use xml dom and not strings?

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not working fully. Pls see comments.

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems ok now.
image

Published and review for beauty pass was made and seems fine.

@iLLiCiTiT iLLiCiTiT merged commit 2d5969a into develop Dec 6, 2022
@github-actions github-actions bot added this to the next-patch milestone Dec 6, 2022
@iLLiCiTiT iLLiCiTiT deleted the bugfix/oiio_conversion_multipart_fix branch December 9, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants