New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General: Oiio conversion multipart fix #4060
Conversation
Looks good but since we are messing up now with xml, shouldn't we parse it and work with it that way instead of hacking it as string? |
I don't know to which code is this related? |
…an't ffmpeg handle
all lines like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not working fully. Pls see comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brief description
Don't define input channels if input is multipart exr.
Description
When converting multipart exr for ffmpeg it can't handle definition of channels on input because there are multiple subimages which cause crash if oiiotool.
Extended few types in xml info result parsing and added ability to receive information about every subimage in exr.
Additional information
The output has all subimages (which can be big exr) that is because ffmpeg then created transparent image without any content. Not sure why but it's an issue. Also if any subimage in the exr has attributes with invalid characters or too long value it would cause issues in ffmpeg too -> future enhancements.
Testing notes: