Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Collection Audio speed up #4110

Merged
merged 4 commits into from
Dec 6, 2022

Conversation

iLLiCiTiT
Copy link
Member

Brief description

Speed up Collect Audio publish plugin.

Description

Collect audio did do a lot of database calls per instance which slowed down collection phase a lot if there was more instances. The plugin was converted from instance plugin to context plugin. That helps to query required data from database for all instances at once without doing it for each individual instance.

Additional info

The plugin is not using legacy_io.Session to get context information. Instead of using get_representation_path is used get_representation_path_with_anatomy.

Testing notes:

  1. Create at least 10 instances each with different asset (e.g. in tray publisher)
  2. Run collection
  3. Compare speed with and without this PR

@iLLiCiTiT iLLiCiTiT marked this pull request as ready for review November 18, 2022 18:13
@iLLiCiTiT iLLiCiTiT self-assigned this Nov 18, 2022
@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label Nov 18, 2022
@iLLiCiTiT iLLiCiTiT merged commit a99c4a8 into develop Dec 6, 2022
@iLLiCiTiT iLLiCiTiT deleted the feature/collect_audio_speed_enhancement branch December 6, 2022 16:25
@github-actions github-actions bot added this to the next-patch milestone Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants