Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Deadline: Build version resolving #4115

Merged
merged 4 commits into from
Nov 24, 2022
Merged

Deadline: Build version resolving #4115

merged 4 commits into from
Nov 24, 2022

Conversation

iLLiCiTiT
Copy link
Member

Brief description

Deadline prelaunch plugin have more sofisticated build version resolving to be used.

Description

Before this PR deadline global pre launch plugin always used last openpype build it found (without comparing prerelease part of version string) which cause issues if the requested version from job lead to older build version.

Additional info

This is fixing edge case usages and development testing. Before this PR the deadline could find for example 3 build versions 3.14.5, 3.14.6-nightly.5 and 3.14.6 from that point both builds 3.14.6-nightly.5 and 3.14.6 were considered as same versions and if job requested version 3.14.5 the environments injection would fail because build 3.14.6 could not find the zip for 3.14.5.

Testing notes:

  1. Prepare multiple build with different versions for deadline plugin
  2. Submit multiple jobs for those different builds
  3. All of them should find correct build

@iLLiCiTiT iLLiCiTiT self-assigned this Nov 21, 2022
@iLLiCiTiT iLLiCiTiT added type: enhancement Enhancements to existing functionality module: Deadline AWS Deadline related features labels Nov 21, 2022
@iLLiCiTiT iLLiCiTiT marked this pull request as ready for review November 23, 2022 10:08
m-u-r-p-h-y
m-u-r-p-h-y approved these changes Nov 24, 2022
View reviewed changes
Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working like a charm

image

@iLLiCiTiT iLLiCiTiT merged commit f1e1a1b into develop Nov 24, 2022
@iLLiCiTiT iLLiCiTiT deleted the feature/deadline_build_version_resolving branch November 24, 2022 09:21
@github-actions github-actions bot added this to the next-patch milestone Nov 24, 2022
@jakubjezek001 jakubjezek001 modified the milestones: 3.14.7, next-patch Nov 25, 2022
@ccaillot ccaillot mentioned this pull request Jun 23, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kalisp kalisp kalisp left review comments

@m-u-r-p-h-y m-u-r-p-h-y m-u-r-p-h-y approved these changes

@64qam 64qam Awaiting requested review from 64qam

@antirotor antirotor Awaiting requested review from antirotor

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
module: Deadline AWS Deadline related features type: enhancement Enhancements to existing functionality
Projects
None yet
Milestone
3.14.8
Development

Successfully merging this pull request may close these issues.
4 participants
@iLLiCiTiT @m-u-r-p-h-y @kalisp @jakubjezek001