Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maya: Looks - add all connections #4135

Merged
merged 1 commit into from Nov 24, 2022

Conversation

antirotor
Copy link
Member

Bug

If file node was connected not using its "primary data" plug, look collector was ignoring it - for example file node driving only with Alpha Out something down the line was missed by collector.

Fix

This is adding allConnection or ac flag to cmds.listHistory to get even those.

Testing

Create shader with texture using Alpha Out to drive something in the material. Look collector should pick it up correctly.

if file nodes are not connected using their "primary data" node, `listHistory` was ignoring them
@antirotor antirotor added type: bug Something isn't working host: Maya labels Nov 24, 2022
@antirotor antirotor self-assigned this Nov 24, 2022
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works fine...
image
Succesfully published the look with only alpha component connected to the shader and loaded via OP loader for check....

@antirotor antirotor merged commit fc79593 into develop Nov 24, 2022
@antirotor antirotor deleted the bugfix/maya-look-collect-all-connections branch November 24, 2022 16:19
@github-actions github-actions bot added this to the next-patch milestone Nov 24, 2022
@jakubjezek001 jakubjezek001 modified the milestones: 3.14.7, next-patch Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Maya type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants