This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Maya: Looks - add all connections #4135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if file nodes are not connected using their "primary data" node, `listHistory` was ignoring them
LiborBatek
approved these changes
Nov 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
If file node was connected not using its "primary data" plug, look collector was ignoring it - for example file node driving only with
Alpha Outsomething down the line was missed by collector.Fix
This is adding
allConnectionoracflag tocmds.listHistoryto get even those.Testing
Create shader with texture using
Alpha Outto drive something in the material. Look collector should pick it up correctly.