Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Extract review handle start offset of sequences #4152

Merged

Conversation

iLLiCiTiT
Copy link
Member

Brief description

Extract review can handle handles offset if input is sequence.

Description

Source of the issue comes when extract review has set tag no-handles and input is sequence of images in that case are combined arguments -start_number and -ss and it seems that -ss should not be used with sequence but is better to change -start_number value instead.

Testing notes:

Validate if output of extract review is ok. Prepare asset with handles and settings with same output but one have no-handles tag

  • input is sequence, output is sequence [with handles]
  • input is sequence, output is sequence [without handles]
  • input is sequence, output is movie [with handles]
  • input is sequence, output is movie [without handles]
  • input is movie, output is anything [with handles]
  • input is movie, output is anything [without handles]

@iLLiCiTiT iLLiCiTiT self-assigned this Nov 30, 2022
@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label Nov 30, 2022
@iLLiCiTiT iLLiCiTiT marked this pull request as ready for review December 1, 2022 09:15
@iLLiCiTiT iLLiCiTiT merged commit 6d38900 into develop Dec 2, 2022
@iLLiCiTiT iLLiCiTiT deleted the bugfix/no_handles_extract_review_with_sequence_input branch December 2, 2022 15:51
@github-actions github-actions bot added this to the next-patch milestone Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants