Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuke: correct detection of viewer and display #4165

Conversation

jakubjezek001
Copy link
Member

Brief description

Regex pattern is now correctly detecting viewer

Description

In case of Aces name convention if Rec.709 was used - regex pattern was falsely detecting Viewer as Rec only. It was causing wrong colorspace settings on OCIODisplay node.

Testing notes:

  1. Go to Nuke ImageIO settings and set Rec.709 (ACES) at your ACES project.
  2. Publish and stop process during Exctract Review Data Mov. Look to OCIODisplay node and see there is Rec.709 set to Viewer.

@jakubjezek001 jakubjezek001 self-assigned this Dec 2, 2022
@ynbot
Copy link
Contributor

ynbot commented Dec 2, 2022

Task linked: OP-4555 [Urgent] Nuke review color shift

@jakubjezek001 jakubjezek001 added host: Nuke type: bug Something isn't working labels Dec 2, 2022
@jrsndl
Copy link
Collaborator

jrsndl commented Dec 6, 2022

I am not sure what to check. I use Rec709 for baking, and it works even without this PR.
No PR applied:

image
and the resulting OCIODisplay node:
image

@jakubjezek001
Copy link
Member Author

I am not sure what to check. I use Rec709 for baking, and it works even without this PR. No PR applied:

image and the resulting OCIODisplay node: image

That is good. But you have different Baking input. Rec.709 (ACES) was the correct one. Before it was returning Rec and it randomly picked for example Rec.2020. Regex only works if (ACES) is in name.

And reason for this is that you could have in some productions sRGB (DNeg).

Copy link
Collaborator

@jrsndl jrsndl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that using () in the name now doesn't break the baking.
Nuke 13.2v4

@jakubjezek001 jakubjezek001 merged commit c67a0b5 into develop Dec 6, 2022
@jakubjezek001 jakubjezek001 deleted the bugfix/OP-4555-Nuke-detect-viewer-and-display-regex-fix branch December 6, 2022 15:34
@github-actions github-actions bot added this to the next-patch milestone Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Nuke type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants