Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maya: Extractor for Unreal SkeletalMesh #4174

Merged
merged 7 commits into from
Dec 9, 2022
Merged

Maya: Extractor for Unreal SkeletalMesh #4174

merged 7 commits into from
Dec 9, 2022
+194 −5

Conversation

simonebarbieri
Copy link
Member

Brief description

Implementation of the extractor of Unreal SkeletalMesh.

Description

This PR implements an extractor of rigs as Unreal SkeletalMesh. As Unreal does not support meshes with faces with more than 4 vertices, it has been included a validator to verify that the mesh is triangulated.

@simonebarbieri simonebarbieri added host: Maya host: UE type: feature Larger, user affecting changes and completely new things labels Dec 5, 2022
@simonebarbieri simonebarbieri self-assigned this Dec 5, 2022
LiborBatek
LiborBatek approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works ok, validator works and repair action too. Model get triangulated and validator doesnt fail then.

@LiborBatek
Copy link
Member

LiborBatek commented Dec 7, 2022 •
edited
Loading

I get this error...
not sure if its somewhat connected to PR but Extractor later fails (this PR is about triangulation/validation which is working ok)

here is the error I get after validation which went ok
image

@simonebarbieri
Copy link
Member Author

I get this error... not sure if its somewhat connected to PR but Extractor later fails (this PR is about triangulation/validation which is working ok)

here is the error I get after validation which went ok image

I think it is caused by this commit: a465315

@antirotor antirotor merged commit e6c5ae5 into develop Dec 9, 2022
@antirotor antirotor deleted the feature/maya-unreal_skeleton_mesh branch December 9, 2022 12:14
@github-actions github-actions bot added this to the next-patch milestone Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiborBatek LiborBatek LiborBatek approved these changes

Assignees

@simonebarbieri simonebarbieri

Labels
host: Maya host: UE type: feature Larger, user affecting changes and completely new things
Projects
None yet
Milestone
3.14.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@simonebarbieri @LiborBatek @antirotor