Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Comment per instance in Publisher #4178

Merged

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Dec 5, 2022

Brief description

Instances in publisher can have ability to set comment per instance.

Description

Collect comment plugin also store comment to each instance in context (so all plugins using it can access it directly). Added plugin which define "comment" attribute per instance and have settings for which families is available. By default is disabled and for none families.

The same should work when instance is sent to farm. Comment should stay on instances (didn't test).

Additional information

Modified instance data sent to farm to contain comment per instance to persist comment from UI.

Testing notes:

  1. Enable the Collect Comment per instance in settings and fill families by your choice (project_settings/global/publish/collect_comment_per_instance)
  2. Run host which use new Publisher tool (e.g. TrayPublisher)
  3. Create instance with family from settings
  4. Select instance and fill it's comment
  5. Publish
  6. Validate that the comment on instance was used where should be (e.g. in ftrack -> make sure comment can be used in note/description)

@ynbot
Copy link
Contributor

ynbot commented Dec 5, 2022

Task linked: OP-4531 comment per item in tray publisher

@iLLiCiTiT iLLiCiTiT self-assigned this Dec 5, 2022
@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label Dec 5, 2022
@iLLiCiTiT iLLiCiTiT merged commit 7c16c15 into develop Dec 6, 2022
@iLLiCiTiT iLLiCiTiT deleted the feature/OP-4531_comment-per-item-in-tray-publisher branch December 6, 2022 08:57
@github-actions github-actions bot added this to the next-patch milestone Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants