Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Integrate thumbnail looks for thumbnail to multiple places #4181

Merged
merged 4 commits into from
Dec 6, 2022

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Dec 6, 2022

Brief description

Integrate thumbnail can look to more places where thumbnail for instance could be found.

Description

Before this PR was thumbnail found only on published representations or from context thumbnail. There are 2 missing sources: First is at key "thumbnailPath" on instance data and second is on not integrated representations. Added these 2 options.

Order of thumbnail path resolving

  1. Look for published representation with name "thumbnail"
  2. Look for not published representation with name "thumbnail"
  3. Look into instance data for key "thumbnailPath"
    If any step has available value but the path is not valid then go to next step until hit end.

Testing notes:

  1. Thumbnails are integrated even if it's representation is not

@iLLiCiTiT iLLiCiTiT self-assigned this Dec 6, 2022
@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label Dec 6, 2022
@iLLiCiTiT iLLiCiTiT requested a review from kalisp December 6, 2022 14:05
@iLLiCiTiT iLLiCiTiT merged commit 272fd1e into develop Dec 6, 2022
@iLLiCiTiT iLLiCiTiT deleted the bugfix/integrate_thumbnail_source branch December 6, 2022 14:29
@github-actions github-actions bot added this to the next-patch milestone Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants