Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deadline: improve environment processing #4182

Merged
merged 3 commits into from
Dec 15, 2022

Conversation

jakubjezek001
Copy link
Member

@jakubjezek001 jakubjezek001 commented Dec 6, 2022

Brief description

Better way of passing environments.

Description

In some occasions there was need for having default keys in job, even those were not yet used in previous dependency job so they could not be passed with list of filtered keys.

The procedure is working now following way.

  1. default set of environment variables are compiled
  2. next class attribute enviro_keys is iterated and found keys are included or overridden from 1. step
  3. last step is taking class attribute environ_job_filter is iterated and available keys in previous job are included or overridden from 2. step

Testing notes:

  1. publish to farm to your favourite host
  2. all should work as before

@jakubjezek001 jakubjezek001 self-assigned this Dec 6, 2022
@jakubjezek001 jakubjezek001 added module: Deadline AWS Deadline related features type: enhancement Enhancements to existing functionality labels Dec 6, 2022
@kalisp
Copy link
Member

kalisp commented Dec 12, 2022

In AE it is failing for me on Publish job in DL because both OPENPYPE_RENDER and OPENPYPE_PUBLISH is marked as 1.
Screenshot 2022-12-12 141552
Screenshot 2022-12-12 125140

@jakubjezek001
Copy link
Member Author

In AE it is failing for me on Publish job in DL because both OPENPYPE_RENDER and OPENPYPE_PUBLISH is marked as 1. Screenshot 2022-12-12 141552 Screenshot 2022-12-12 125140

Its fixed now, tested in Nuke and works as expected.

Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working in AE

@jakubjezek001 jakubjezek001 merged commit 1256c67 into develop Dec 15, 2022
@github-actions github-actions bot added this to the next-patch milestone Dec 15, 2022
@jakubjezek001 jakubjezek001 deleted the feature/deadline_submit_job_env_refactory branch December 15, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: Deadline AWS Deadline related features type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants