Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maya: Enhanced ASS publishing #4196

Merged
merged 22 commits into from Dec 9, 2022

Conversation

antirotor
Copy link
Member

Brief description

Reviewable ass extractor improvements.

Description

This is feature parallel to client extractor, with settings ported to OpenPype workflows with objectset and project settings.

Discussion

I don't agree with having an exportSequence attribute because in OpenPype workflows you can define frame range easily, so it makes more sense to just support single frame publishes (which it already does). I propose to remove this attribute to simplify code and workflow.
So to note, current workflow of using current frame to export is prone to user errors and unpredictability.

Testing notes:

  1. Create and publish Ass instance.
  2. Use Arnold's kick executable to validate renders.

@antirotor antirotor added type: enhancement Enhancements to existing functionality host: Maya labels Dec 8, 2022
@ynbot
Copy link
Contributor

ynbot commented Dec 8, 2022

Task linked: OP-3924 Implement ASS Extractor

@antirotor
Copy link
Member Author

exportSequence is a matter of controversy indeed. I can imagine the need for quick option (from the user perspective) to simply check something and without having to set frame range and disabling frame range validator export just one frame for whatever reason...

This said, I would remove it from here because it will be much easier (again from the user perspective) to set it when we switch Maya to the new publisher.

Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ASS instance publishing works as expected.

tested with Maya2023.3, MtoA 5.2.1.0

image

@antirotor antirotor merged commit 64b7276 into develop Dec 9, 2022
@antirotor antirotor deleted the feature/OP-3924_implement-ass-extractor branch December 9, 2022 10:42
@github-actions github-actions bot added this to the next-patch milestone Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Maya type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants