Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuke: fixed imageio node overrides subset filter #4202

Conversation

jakubjezek001
Copy link
Member

@jakubjezek001 jakubjezek001 commented Dec 9, 2022

Brief description

Subset filter works even mixture of letter sizes in subset name.

Description

Once mixture of sizes was used (ex. _this_ButThat), subset filter was not able to detect correctly node override from imageio nodes preset.

Testing notes:

  1. Create new preset in project_settings/nuke/imageio/nodes/overrideNodes, which would override the CreateWriteRender plugin, with Node Node Class to Write from project_settings/nuke/imageio/nodes/requiredNodes
    image

  2. add subset name filter to _bla_BlaBla

  3. add the _bla_BlaBla also to project_settings/nuke/create/CreateWriteRender/defaults
    image

  4. Open nuke, select a node, Create Render node and set Variant to _bla_BlaBla

  5. created node should be pink

@jakubjezek001 jakubjezek001 self-assigned this Dec 9, 2022
@ynbot
Copy link
Contributor

ynbot commented Dec 9, 2022

@64qam
Copy link
Member

64qam commented Dec 9, 2022

I can't approve it. The subset name I created was lowercase. However, the creator turned it into upper case. When I created an uppercase subset it didn't work either and still got not overridden node
image

@jakubjezek001
Copy link
Member Author

I can't approve it. The subset name I created was lowercase. However, the creator turned it into upper case. When I created an uppercase subset it didn't work either and still got not overridden node image

Valid point, but it is the issue of backend I believe @iLLiCiTiT , right?

@iLLiCiTiT
Copy link
Member

To be honest I don't understand the PR so I can't tell.

What happened to @64qam is that his subset name template is {family}_{Task}_{Variant} (at least it looks like). In that case variant "bla_bla" must become "Bla_bla" and there is nothing I can do about it.

@jakubjezek001 jakubjezek001 merged commit 2fcaa34 into develop Dec 16, 2022
@jakubjezek001 jakubjezek001 deleted the bugfix/OP-4598_Nuke-CreateWriteRender-settings-dont--work branch December 16, 2022 11:17
@github-actions github-actions bot added this to the next-patch milestone Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Nuke type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants