Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General: Default command for headless mode is interactive #4203

Merged
merged 3 commits into from Dec 13, 2022
Merged

General: Default command for headless mode is interactive #4203

merged 3 commits into from Dec 13, 2022
+7 −1

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Dec 9, 2022 •
edited

Brief description

Print help instead of running tray by default if headless mode is enabled and no command is entered.

Additional info

The only reason is that trying to launch tray when headless is explicitly defined is "not right".

The command won't do anything if openpype_gui executable is used on windows (there is no right command to run in that case).

Testing notes:

  1. Start openpype executable with only --headless argument

@iLLiCiTiT iLLiCiTiT self-assigned this Dec 9, 2022
@iLLiCiTiT iLLiCiTiT requested a review from kalisp December 9, 2022 12:40
@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label Dec 9, 2022
@antirotor
Copy link
Member

I guess that doing nothing is not good way to go. It might suggest something is wrong. I would print help instead

@iLLiCiTiT
Copy link
Member Author

I would print help instead

Done

m-u-r-p-h-y
m-u-r-p-h-y approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works both ways

image

image

@iLLiCiTiT iLLiCiTiT merged commit ad9f185 into develop Dec 13, 2022
@iLLiCiTiT iLLiCiTiT deleted the feature/default_cli_for_headless branch December 13, 2022 12:11
@github-actions github-actions bot added this to the next-patch milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-u-r-p-h-y m-u-r-p-h-y m-u-r-p-h-y approved these changes

@antirotor antirotor Awaiting requested review from antirotor

@kalisp kalisp Awaiting requested review from kalisp

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Milestone
3.14.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iLLiCiTiT @antirotor @m-u-r-p-h-y