Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Use qtpy in modules and hosts UIs which are running in OpenPype process #4225

Merged
merged 3 commits into from Dec 16, 2022

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Dec 13, 2022

Brief description

Use qtpy module instead of Qt in UIs which are running in OpenPype processes or in processes which install known binding.

Testing notes:

Test if modules have working UI tools and if tools are working in modified hosts.
Modules:

  • Ftrack (login)
  • Clockify (login)
  • Kitsu (login)
  • Shotgrid (login)
  • Sync server
  • Log viewer
  • Admin > Console
  • Timers manager (on windows)
    Hosts:
  • Muster
  • Aftereffects
  • Blender
  • Fusion
  • Harmony
  • Photoshop
  • TVPaint
  • Unreal

@ynbot
Copy link
Contributor

ynbot commented Dec 13, 2022

Task linked: OP-4632 qtpy in module tools

@iLLiCiTiT iLLiCiTiT self-assigned this Dec 13, 2022
@iLLiCiTiT iLLiCiTiT added the type: refactor Structural changes not affecting functionality label Dec 13, 2022
@kalisp
Copy link
Member

kalisp commented Dec 14, 2022

Shouldnt this point to release/3.15.x instead of develop?

@iLLiCiTiT
Copy link
Member Author

Shouldnt this point to release/3.15.x instead of develop?

It's not adding any dependency or change startup logic so not really (it does not require new build).

Copy link
Member

@simonebarbieri simonebarbieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blender and Unreal work fine

@iLLiCiTiT iLLiCiTiT merged commit d62790b into develop Dec 16, 2022
@iLLiCiTiT iLLiCiTiT deleted the feature/OP-4632_qtpy-in-module-tools branch December 16, 2022 10:54
@github-actions github-actions bot added this to the next-patch milestone Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactor Structural changes not affecting functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants