Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/pype version in tray #379

Merged
merged 3 commits into from
Jul 27, 2020
Merged

feature/pype version in tray #379

merged 3 commits into from
Jul 27, 2020

Conversation

iLLiCiTiT
Copy link
Member

Changes

  • added item to tray menu with version, client version and client name
  • client version and client name can be set in config.ini in pype-setup e.g.:
[CLIENT]
subversion=1
client_name=Pype Club
  • subversion and client_name are optional
    • menu item with version is shown only if at least one key is set

image

@iLLiCiTiT iLLiCiTiT self-assigned this Jul 24, 2020
@iLLiCiTiT iLLiCiTiT requested a review from a team July 24, 2020 09:17
@mkolar mkolar changed the base branch from release/2.11.0 to 2.x/develop July 26, 2020 19:56
@mkolar mkolar changed the base branch from 2.x/develop to release/2.11.0 July 26, 2020 21:31
mkolar
mkolar requested changes Jul 26, 2020
View reviewed changes
Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, but we should be showing the main version under all circumstances. Not only when client subversion is set.

@mkolar mkolar merged commit d63e51d into release/2.11.0 Jul 27, 2020
@mkolar mkolar deleted the feature/pype_version_in_tray branch July 28, 2020 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkolar mkolar mkolar requested changes

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iLLiCiTiT @mkolar