Multiple reviews where being overwritten to one. #424
Conversation
|
I assume this was when making multiple reviews from multiple cameras? |
|
The use case I have is to publish a "main" and "precomp" review. The precomp have isolated view and the main has everything. Multiple cameras would be another use case I guess. |
| @@ -69,7 +69,12 @@ def process(self, instance): | |||
| instance.data['remove'] = True | |||
| i += 1 | |||
| else: | |||
| instance.data['subset'] = task + 'Review' | |||
| subset = "{}{}{}".format( | |||
There was a problem hiding this comment.
Works well, however we'll need to add backwards compatible option in here. Some of our clients are relying on this in production now and have custom scripts and setup locked to previous neming (without the subset name), we can't change this mid-project.
Let's please add a switch configurable using self.legacy=true presetable attribute, that defaults to True and when on behaves as before. Like that it can go out in 2.12 at the end of the week.
From 2.13 or 14, we can then switch it OFF by default. and in pype 3 remove it. what do you think?
There was a problem hiding this comment.
Sounds like a good idea. Done.
| @@ -69,7 +69,16 @@ def process(self, instance): | |||
| instance.data['remove'] = True | |||
| i += 1 | |||
| else: | |||
| instance.data['subset'] = task + 'Review' | |||
| if instance.data.get("legacy", True): | |||
There was a problem hiding this comment.
This should rather be a class attribute, that way it is configurable per project and per studio. It will make the transition much easier.
It's not something that the artist should have control over, but studio config should.
There was a problem hiding this comment.
Cool, that makes sense. Done.
No description provided.